[18.0][ADD] product_packaging_template_sale: New module#2134
Open
marielejeune wants to merge 2 commits intoOCA:18.0from
Open
[18.0][ADD] product_packaging_template_sale: New module#2134marielejeune wants to merge 2 commits intoOCA:18.0from
marielejeune wants to merge 2 commits intoOCA:18.0from
Conversation
yvaucher
reviewed
Nov 24, 2025
| """ | ||
| res = super().write(vals) | ||
| if "sales" in vals: | ||
| self.mapped("packaging_ids").write({"sales": vals["sales"]}) |
Member
There was a problem hiding this comment.
Any reason to not override the _get_value_to_propagate method?
Contributor
Author
There was a problem hiding this comment.
No, the _get_value_to_propagate method was added afterwards, due to a review on the other PR, and I forgot to change it here. Done now.
marielejeune
force-pushed
the
18.0-add-product_packaging_template_sale
branch
from
e53d044 to
be993dd
Compare
Adds the 'Sales' information on packaging template level
marielejeune
force-pushed
the
18.0-add-product_packaging_template_sale
branch
from
be993dd to
d804a01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2133
This module extends the
product_packaging_templatethat addspackaging on template level.
The goal of this module is being able to set the "Sales" configuration
(determining if a packaging is usable in sale orders) on the packaging
template level.